Fix growpart error with older blkid versions #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @holmanb, That might be true that CentOS 7 (and Debian 9 "Stretch") will not recieve updates, Thanks for the heads-up, I've signed the CLA. Kind regards, |
agreed, and no objections to the change
Confirmed |
holmanb
approved these changes
Apr 5, 2024
|
@balcsida Could you please rebase on the tip of main to pick up the ci fix? Cnce that passes I'll merge. |
balcsida
force-pushed
the
fix/growpart-blkid-error
branch
from
6d01762 to
1e5c0fc
Compare
MingcongBai
pushed a commit
to AOSC-Tracking/cloud-utils
that referenced
this pull request
May 13, 2024
Certain older distributions (e.g. CentOS 7.9) include outdated versions (from 2013) of `blkid`. Because [long options were added in 2017](util-linux/util-linux@15a74f7), using the "original", short form to check the version would make this script work with these `blkid` versions instead of failing with `blkid: invalid option -- '-'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain older distributions (e.g. CentOS 7.9) include outdated versions (from 2013) of
blkid.Because long options were added in 2017, using the "original", short form to check the version would make this script work with these
blkidversions instead of failing withblkid: invalid option -- '-'